[asterisk-dev] [Code Review] 2708: Fix documentation replication issues (no regex this time)

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2708/#review9265
-----------------------------------------------------------

Ship it!


A few things to add:

* In the CHANGES and UPGRADE file, note that libxslt is now optionally used to improve XML documentation. If libxslt isn't present, some XML documentation may be incomplete (it will be)
* In the make_deps script, add libxslt
* If they don't have libxslt, use a #else and emit a NOTICE at least that XSLT support wasn't found. XML documentation may be incomplete (it will be)

That really is the only issue I have with this: if you don't have libxslt, your event documentation is going to be lacking. As long as it doesn't blow up, however, that isn't the worst thing in the world (and AMI event documentation is less useful in CLI than in other mediums)



- Matt Jordan


On July 26, 2013, 8:46 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2708/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 8:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds xslt handling support to Asterisk and a stylesheet that generates channel and bridge snapshots on the fly with appropriate prefixes, all from tags like: <channel_snapshot prefix="Dest"/>
> 
> This also corrects existing documentation to use this new single-tag solution.
> 
> 
> Diffs
> -----
> 
>   /configure UNKNOWN 
>   /trunk/Makefile 395557 
>   /trunk/apps/app_agent_pool.c 395557 
>   /trunk/apps/app_meetme.c 395557 
>   /trunk/apps/app_minivm.c 395557 
>   /trunk/apps/app_queue.c 395557 
>   /trunk/apps/app_stack.c 395557 
>   /trunk/apps/confbridge/confbridge_manager.c 395557 
>   /trunk/channels/chan_dahdi.c 395557 
>   /trunk/channels/chan_sip.c 395557 
>   /trunk/channels/sig_pri.c 395557 
>   /trunk/configure.ac 395557 
>   /trunk/doc/appdocsxml.dtd 395557 
>   /trunk/doc/snapshots.xslt PRE-CREATION 
>   /trunk/funcs/func_global.c 395557 
>   /trunk/include/asterisk/autoconfig.h.in 395557 
>   /trunk/main/Makefile 395557 
>   /trunk/main/aoc.c 395557 
>   /trunk/main/core_local.c 395557 
>   /trunk/main/features.c 395557 
>   /trunk/main/manager.c 395557 
>   /trunk/main/manager_bridges.c 395557 
>   /trunk/main/manager_channels.c 395557 
>   /trunk/main/manager_mwi.c 395557 
>   /trunk/main/rtp_engine.c 395557 
>   /trunk/main/stasis_bridges.c 395557 
>   /trunk/main/stasis_channels.c 395557 
>   /trunk/main/xml.c 395557 
>   /trunk/makeopts.in 395557 
>   /trunk/res/parking/parking_manager.c 395557 
>   /trunk/res/res_agi.c 395557 
> 
> Diff: https://reviewboard.asterisk.org/r/2708/diff/
> 
> 
> Testing
> -------
> 
> Verified that XML is still parsed properly by Asterisk when libxslt is present and fails to expand the new tags when it isn't (without failing catastrophically).
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/40859426/attachment.htm>