[asterisk-dev] [Code Review] 2718: pjsip tests: Test nominal inbound registrations with multiple contacts

[jbigelow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2718/
-----------------------------------------------------------

(Updated July 31, 2013, 5:30 p.m.)


Review request for Asterisk Developers.


Changes
-------

Changed tolerance of the expires parameter from 1 second to 5 seconds.


Repository: testsuite


Description
-------

This test sends registrations using a multiple contacts with and without authentication over IPv4/IPv6 and UDP/TCP. This is to ensure that multiple contacts are added to the AOR for each defined endpoint with the correct expiration. These also ensure that the expiration is correctly set whether it's specified in the 'Expires' header, in the 'expires' parameter of Contact headers, or based on the value of the default_expiration pjsip.conf config option. This covers test #2 & #3 of the nominal inbound registrations listed on the test plan page of the wiki.

A single ast_test_suite_event_notify was added to res_pjsip_registrar.c to make this test possible. See review 2700 (https://reviewboard.asterisk.org/r/2700/)


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/mixed/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/mixed/unauthed/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/mixed/unauthed/sipp/mixed-noauth-contact-expiry-ipv4.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/mixed/unauthed/sipp/mixed-noauth-contact-expiry-ipv6.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/mixed/unauthed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/authed/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/authed/sipp/register-auth-multi-contact-expiry-ipv4.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/authed/sipp/register-auth-multi-contact-expiry-ipv6.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/authed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/unauthed/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/unauthed/sipp/register-noauth-multi-contact-expiry-ipv4.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/unauthed/sipp/register-noauth-multi-contact-expiry-ipv6.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts/unauthed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/tests.yaml 3972 

Diff: https://reviewboard.asterisk.org/r/2718/diff/


Testing
-------

* Ensured the tests fail if:
- the Test Events aren't received or do not match.
- the contact header in the 200 OK isn't what is expected
* Review logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP.


Thanks,

jbigelow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130731/fe9c2840/attachment-0001.htm>