[asterisk-dev] [Code Review] 2699: pjsip tests: Test nominal inbound registrations with a single contact

[jbigelow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2699/
-----------------------------------------------------------

(Updated July 31, 2013, 5:10 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added checking of the expires parameter on the 200 OK and made it more tolerant as suggested on review 2718.


Repository: testsuite


Description
-------

This test sends registrations using a single contact with and without authentication over IPv4/IPv6 and UDP/TCP. This is to ensure that only a single contact is added to the AOR for each defined endpoint. This covers test #1 of the nominal inbound registrations listed on the test plan page of the wiki.

A single ast_test_suite_event_notify was added to res_pjsip_registrar.c to make this test possible. See review 2700 (https://reviewboard.asterisk.org/r/2700/)


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/sipp/register-auth.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/sipp/register-noauth.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/tests.yaml 3972 

Diff: https://reviewboard.asterisk.org/r/2699/diff/


Testing
-------

* Ensured the tests fail if:
- the Test Events aren't received or do not match.
- the contact header in the 200 OK isn't what is expected
* Review logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP.


Thanks,

jbigelow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130731/af7dceb6/attachment-0001.htm>