[asterisk-dev] [Code Review] 2703: Strip down the old event system

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2703/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-22139
    https://issues.asterisk.org/jira/browse/ASTERISK-22139


Repository: Asterisk


Description
-------

This removes unused code, event types, IE pltypes, and event IE types where possible and makes several functions private that were once public. This includes a renumbering of the remaining event and IE types which breaks binary compatibility with previous versions. The last remaining consumers of the old event system (or parts thereof) are main/security_events.c, res/res_security_log.c, tests/test_cel.c, tests/test_event.c, main/cel.c, and the CEL backends.


Diffs
-----

  trunk/apps/app_queue.c 395498 
  trunk/apps/app_voicemail.c 395498 
  trunk/channels/chan_dahdi.c 395498 
  trunk/channels/chan_iax2.c 395498 
  trunk/channels/chan_mgcp.c 395498 
  trunk/channels/chan_sip.c 395498 
  trunk/channels/chan_skinny.c 395498 
  trunk/channels/chan_unistim.c 395498 
  trunk/channels/sig_pri.h 395498 
  trunk/channels/sig_pri.c 395498 
  trunk/funcs/func_presencestate.c 395498 
  trunk/include/asterisk/devicestate.h 395498 
  trunk/include/asterisk/event.h 395498 
  trunk/include/asterisk/event_defs.h 395498 
  trunk/include/asterisk/security_events_defs.h 395498 
  trunk/main/ccss.c 395498 
  trunk/main/devicestate.c 395498 
  trunk/main/event.c 395498 
  trunk/main/manager.c 395498 
  trunk/main/pbx.c 395498 
  trunk/main/presencestate.c 395498 
  trunk/main/security_events.c 395498 
  trunk/res/parking/parking_applications.c 395498 
  trunk/res/parking/parking_manager.c 395498 
  trunk/res/parking/parking_ui.c 395498 
  trunk/res/res_jabber.c 395498 
  trunk/res/res_parking.c 395498 
  trunk/res/res_security_log.c 395498 
  trunk/res/res_xmpp.c 395498 
  trunk/tests/test_cel.c 395498 
  trunk/tests/test_event.c 395498 

Diff: https://reviewboard.asterisk.org/r/2703/diff/


Testing
-------

Made sure that CEL and event system unit tests still pass.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130726/c9bf1106/attachment.htm>