[asterisk-dev] [Code Review] 2692: chan_pjsip: T.38 Fax Support

[Joshua Colp]

> On July 25, 2013, 8:07 p.m., Mark Michelson wrote:
> > /trunk/res/res_sip_t38.c, lines 417-420
> > <https://reviewboard.asterisk.org/r/2692/diff/3/?file=42474#file42474line417>
> >
> >     Are you supposed to ast_frfree(f) before setting it to a new value?

If there were a frame, yes, but there isn't.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2692/#review9215
-----------------------------------------------------------


On July 25, 2013, 4:34 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2692/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 4:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds T.38 support to chan_pjsip. A seperate optional module has been created which contains the T.38 state machine, SDP parsing/generation, and UDPTL sending/receiving.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_gulp.c 395397 
>   /trunk/include/asterisk/res_sip.h 395397 
>   /trunk/include/asterisk/res_sip_session.h 395397 
>   /trunk/res/res_sip.c 395397 
>   /trunk/res/res_sip/sip_configuration.c 395397 
>   /trunk/res/res_sip_session.c 395397 
>   /trunk/res/res_sip_session.exports.in 395397 
>   /trunk/res/res_sip_t38.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2692/diff/
> 
> 
> Testing
> -------
> 
> Tested sending and receiving using Zoiper.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130726/33546b0f/attachment.htm>