[asterisk-dev] [Code Review] 2701: Improved feature limits interval hook implementaion.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2701/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-22107
    https://issues.asterisk.org/jira/browse/ASTERISK-22107


Repository: Asterisk


Description
-------

* Fixed feature limits to not use special members of struct ast_bridge_features.

* Fixed memory leak in off nominal paths of bridge_builtin_set_limits().

* Fixed off nominal path in ast_bridge_features_limits_construct() freeing unallocated memory if it was not called by bridge_builtin_set_limits().

* Made bridge_builtin_interval_features.so unloadable.

* Simplified parking's use of its duration interval hook.

* Made BridgeWait S option not depend upon another module being loaded.


Diffs
-----

  /trunk/apps/app_bridgewait.c 395492 
  /trunk/bridges/bridge_builtin_interval_features.c 395492 
  /trunk/include/asterisk/bridge_features.h 395492 
  /trunk/main/bridge.c 395492 
  /trunk/res/parking/parking_bridge_features.c 395492 

Diff: https://reviewboard.asterisk.org/r/2701/diff/


Testing
-------

Interval hooks (start, duration, end) still fire.
The bridge_builtin_interval_features.so module can be unloaded and reloaded successfully.
The BridgeWait S option still works.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130726/2e6df617/attachment.htm>