[asterisk-dev] [Code Review] 2695: Add CLI/AMI commands to force chan_pjsip actions

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2695/#review9210
-----------------------------------------------------------



trunk/res/res_sip_notify.c
<https://reviewboard.asterisk.org/r/2695/#comment18160>

    This documentation is incorrect. Upon reading the function it takes variables from the manager action and uses those to create headers in the NOTIFY.



trunk/res/res_sip_notify.c
<https://reviewboard.asterisk.org/r/2695/#comment18161>

    You've changed this to stop referring to an endpoint name as a channel, so change the error message as well.



trunk/res/res_sip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2695/#comment18162>

    Pedantic: retrieve_registration



trunk/res/res_sip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2695/#comment18164>

    I also think that this should be renamed. A user may interpret the "pjsip unregister" command as forcefully removing the registration for an inbound registration.



trunk/res/res_sip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2695/#comment18163>

    Expand this documentation a bit. This will only unregister the specific contact added by this registration, it won't remove them all.



trunk/res/res_sip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2695/#comment18165>

    Send a REGISTER request


- Joshua Colp


On July 24, 2013, 4:42 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2695/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 4:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21939
>     https://issues.asterisk.org/jira/browse/ASTERISK-21939
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds CLI and AMI commands for unregistration of chan_pjsip outbound registrations, adds an AMI command for forcing the qualification of a chan_pjsip endpoint, and documents and reworks the chan_pjsip NOTIFY commands.
> 
> In the process of implementing this, two refcounting bugs in the outbound registration code were also fixed.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_sip.c 395266 
>   trunk/res/res_sip/include/res_sip_private.h 395266 
>   trunk/res/res_sip/sip_options.c 395266 
>   trunk/res/res_sip_notify.c 395266 
>   trunk/res/res_sip_outbound_registration.c 395266 
> 
> Diff: https://reviewboard.asterisk.org/r/2695/diff/
> 
> 
> Testing
> -------
> 
> Tested all new commands for chan_pjsip against a remote chan_sip.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130725/b11f11af/attachment-0001.htm>