[asterisk-dev] [Code Review] 2696: chan_pjsip: Improve initial INVITE handling, session reference counting, and CANCEL handling

Joshua Colp reviewboard at asterisk.org
Wed Jul 24 16:23:33 CDT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated July 24, 2013, 9:23 p.m.)

Review request for Asterisk Developers and Mark Michelson.


Incorporated review feedback.

Repository: Asterisk


The attached change improves initial INVITE handling so it does not crash under certain circumstances.

1. The session reference count is now incremented when a reference is taken by INVITE session, previously it stole it.
2. Most initial INVITE handling now occurs as a serialized task within the session.
3. For cases where the remote side is broken and sends a CANCEL before receiving a provisional response we now detect and reject it.

Diffs (updated)

  /trunk/channels/chan_gulp.c 395284 
  /trunk/res/res_sip/sip_distributor.c 395284 
  /trunk/res/res_sip_session.c 395284 

Diff: https://reviewboard.asterisk.org/r/2696/diff/


Tested normal scenarios with calls coming in, confirmed happy.
Wrote a sipp scenario file to test CANCEL situation (before and after provisional response), confirmed happy.


Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130724/91e48433/attachment.htm>

More information about the asterisk-dev mailing list