[asterisk-dev] [Code Review] 2692: chan_pjsip: T.38 Fax Support

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2692/#review9206
-----------------------------------------------------------



/trunk/channels/chan_gulp.c
<https://reviewboard.asterisk.org/r/2692/#comment18153>

    s/luck/unlock/



/trunk/res/res_sip_t38.c
<https://reviewboard.asterisk.org/r/2692/#comment18154>

    I think this needs to follow similar logic as what is used in the RTP code in order to allow for IPv6 or IPv4 to be used.
    
    You'd also need to be sure to change SDP generation code.


- Mark Michelson


On July 23, 2013, 1:43 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2692/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 1:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds T.38 support to chan_pjsip. A seperate optional module has been created which contains the T.38 state machine, SDP parsing/generation, and UDPTL sending/receiving.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_gulp.c 395102 
>   /trunk/include/asterisk/res_sip.h 395101 
>   /trunk/include/asterisk/res_sip_session.h 395102 
>   /trunk/res/res_sip.c 395101 
>   /trunk/res/res_sip/sip_configuration.c 395101 
>   /trunk/res/res_sip_session.c 395102 
>   /trunk/res/res_sip_session.exports.in 395102 
>   /trunk/res/res_sip_t38.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2692/diff/
> 
> 
> Testing
> -------
> 
> Tested sending and receiving using Zoiper.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130724/21cefa9e/attachment.htm>