[asterisk-dev] [Code Review] 2681: Restore chan_dahdi native bridging and PRI tromboned call elimination.

[rmudgett]

> On July 22, 2013, 11:41 p.m., Matt Jordan wrote:
> > /trunk/channels/dahdi/bridge_native_dahdi.c, line 677
> > <https://reviewboard.asterisk.org/r/2681/diff/2/?file=41542#file41542line677>
> >
> >     "is needed"

Added a ';' after private to better separate the two items.  Only the signaling value of 0 indicates a pseudo channel.


> On July 22, 2013, 11:41 p.m., Matt Jordan wrote:
> > /trunk/channels/dahdi/bridge_native_dahdi.c, lines 446-447
> > <https://reviewboard.asterisk.org/r/2681/diff/2/?file=41542#file41542line446>
> >
> >     I think this could be an ast_verb(3, ...). It's generally useful to see when things start being natively bridged

It originally was a verbose message.  I changed it to a debug message to reduce potential confusion.  Things like playing a file or COLP updates will momentarily take the call out of true native bridging even though the channel technology does not change.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2681/#review9202
-----------------------------------------------------------


On July 16, 2013, 8:55 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2681/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 8:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21886
>     https://issues.asterisk.org/jira/browse/ASTERISK-21886
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Create a native_dahdi bridging technology for use with the new bridging API.
> 
> The new bridging technology is part of the chan_dahdi channel driver because it is very specific to that driver.  Rather than include the new code directly into chan_dahdi.c the new bridge technology is in its own file and linked into chan_dahdi.so.  A large part of this change is the mechanical process of moving declarations around so chan_dahdi.c can be split up into more files later.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_softmix.c 394511 
>   /trunk/channels/Makefile 394511 
>   /trunk/channels/chan_dahdi.h PRE-CREATION 
>   /trunk/channels/chan_dahdi.c 394511 
>   /trunk/channels/dahdi/bridge_native_dahdi.h PRE-CREATION 
>   /trunk/channels/dahdi/bridge_native_dahdi.c PRE-CREATION 
>   /trunk/main/bridging.c 394511 
> 
> Diff: https://reviewboard.asterisk.org/r/2681/diff/
> 
> 
> Testing
> -------
> 
> Analog calls and attended transfers continue to work.
> Analog three way and ringing three way calls continue to work.
> Analog call waiting still works.
> ISDN phone attended transfers still work.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130723/7d9b608d/attachment.htm>