[asterisk-dev] [Code Review] 2689: Add two new stack related applications - GosubEntry and StackPopGoto

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2689/#review9191
-----------------------------------------------------------



/trunk/apps/app_stack.c
<https://reviewboard.asterisk.org/r/2689/#comment18123>

    This needs to be rewritten.  While I read the Jira issue and understand the syntax, the description here is not at all clear.



/trunk/apps/app_stack.c
<https://reviewboard.asterisk.org/r/2689/#comment18124>

    While I understand this as a possible exercise for the author to understand the API, combining two applications does not sound like a good precedent we want to set.
    
    We could also write PlaybackGoto, PlaybackHangup, PlaybackGosub, and various other combinations of two applications, when it would clearly be better simply to invoke those applications separately.


- Tilghman Lesher


On July 22, 2013, 2:41 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2689/
> -----------------------------------------------------------
> 
> (Updated July 22, 2013, 2:41 a.m.)
> 
> 
> Review request for Asterisk Developers and Corey Farrell.
> 
> 
> Bugs: ASTERISK-21390
>     https://issues.asterisk.org/jira/browse/ASTERISK-21390
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds to new stack-related applications to Asterisk - GosubEntry and StackPopGoto.
> 
> GosubEntry allows the dialplan to modify the LOCAL variable values while in a Gosub stack frame.
> 
> StackPopGoto lets you pop off the next stack frame and immediately goto that location. Using the GosubEntry application, you can modify a LOCAL channel variable on the current stack frame and use it as input to this application.
> 
> {note}
> This patch was written by Corey Farrell - see ASTERISK-21390. I tweaked it slightly for coding guidelines and formatting.
> {note}
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 394981 
>   /trunk/apps/app_stack.c 394981 
> 
> Diff: https://reviewboard.asterisk.org/r/2689/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130722/2280c2c5/attachment-0001.htm>