[asterisk-dev] [Code Review] 2683: Add DTLS-SRTP support to chan_pjsip

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2683/
-----------------------------------------------------------

(Updated July 19, 2013, 1:47 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address review comments.


Bugs: ASTERISK-21419
    https://issues.asterisk.org/jira/browse/ASTERISK-21419


Repository: Asterisk


Description
-------

This patch introduces DTLS-SRTP support to chan_pjsip and the options necessary to configure it including an option to allow choosing between 32 and 80 byte SRTP tag lengths.

During the implementation and testing of this patch, three other bugs were found and their fixes are included with this patch. The two in chan_sip were a segfault relating to DTLS setup and mistaken call rejection.  The third bug fix prevents chan_pjsip from attempting to perform bridge optimization between two endpoints if either of them is running any form of SRTP.


Diffs (updated)
-----

  trunk/channels/chan_gulp.c 394806 
  trunk/channels/chan_sip.c 394806 
  trunk/include/asterisk/res_sip.h 394806 
  trunk/include/asterisk/res_sip_session.h 394806 
  trunk/res/res_sip.c 394806 
  trunk/res/res_sip/sip_configuration.c 394806 
  trunk/res/res_sip_sdp_rtp.c 394806 
  trunk/res/res_sip_session.c 394806 

Diff: https://reviewboard.asterisk.org/r/2683/diff/


Testing
-------

Hand testing against chan_sip and verification that behavior does not change when replaced with chan_sip.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130719/b72d7e5b/attachment.htm>