[asterisk-dev] [Code Review] 2686: Test Cross-Origin Resource Sharing configuration

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2686/#review9185
-----------------------------------------------------------

Ship it!


Minor nits; fix those, and it's good to go.


/asterisk/trunk/tests/rest_api/CORS/configs/ast1/ari.conf
<https://reviewboard.asterisk.org/r/2686/#comment18118>

    blob



/asterisk/trunk/tests/rest_api/CORS/run-test
<https://reviewboard.asterisk.org/r/2686/#comment18116>

    You should be able to omit the "%s" %; you already have the string you want.



/asterisk/trunk/tests/rest_api/CORS/run-test
<https://reviewboard.asterisk.org/r/2686/#comment18117>

    You may also want to check that the header matches the expected value.


- David Lee


On July 19, 2013, 11:15 a.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2686/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 11:15 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21278
>     https://issues.asterisk.org/jira/browse/ASTERISK-21278
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Make sure that various CORS origin configs work and get parsed as expected.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast1/ari.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast1/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast2/ari.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast2/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast3/ari.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast3/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast4/ari.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/configs/ast4/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/run-test PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/CORS/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/tests.yaml 3929 
> 
> Diff: https://reviewboard.asterisk.org/r/2686/diff/
> 
> 
> Testing
> -------
> 
> It's a test.  It tests things.  I tested the test.  It tested what I asked it to test, and it failed where I expected (when flipping booleans to...test the test).
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130719/1e7f0674/attachment.htm>