[asterisk-dev] [Code Review] 2681: Restore chan_dahdi native bridging and PRI tromboned call elimination.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2681/#review9166
-----------------------------------------------------------



/trunk/channels/chan_dahdi.h
<https://reviewboard.asterisk.org/r/2681/#comment18075>

    I won't go crazy demanding doxygen comments on everything in this header.
    
    Public functions however *really* should have them.
    
    While you're add it, I would prefix every public function with "dahdi_" to avoid naming collisions. update_conf, enable_dtmf_detect, and disable_dtmf_detect are generic enough that they could conceivably cause a problem in the far flung future.



/trunk/channels/dahdi/bridge_native_dahdi.h
<https://reviewboard.asterisk.org/r/2681/#comment18076>

    Since these are protected to chan_dahdi, prefix them with "dahdi_".


- Matt Jordan


On July 16, 2013, 8:55 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2681/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 8:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21886
>     https://issues.asterisk.org/jira/browse/ASTERISK-21886
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Create a native_dahdi bridging technology for use with the new bridging API.
> 
> The new bridging technology is part of the chan_dahdi channel driver because it is very specific to that driver.  Rather than include the new code directly into chan_dahdi.c the new bridge technology is in its own file and linked into chan_dahdi.so.  A large part of this change is the mechanical process of moving declarations around so chan_dahdi.c can be split up into more files later.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_softmix.c 394511 
>   /trunk/channels/Makefile 394511 
>   /trunk/channels/chan_dahdi.h PRE-CREATION 
>   /trunk/channels/chan_dahdi.c 394511 
>   /trunk/channels/dahdi/bridge_native_dahdi.h PRE-CREATION 
>   /trunk/channels/dahdi/bridge_native_dahdi.c PRE-CREATION 
>   /trunk/main/bridging.c 394511 
> 
> Diff: https://reviewboard.asterisk.org/r/2681/diff/
> 
> 
> Testing
> -------
> 
> Analog calls and attended transfers continue to work.
> Analog three way and ringing three way calls continue to work.
> Analog call waiting still works.
> ISDN phone attended transfers still work.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130719/9a2ad563/attachment.htm>