[asterisk-dev] [Code Review] 2677: Fix bridge/channel AMI event ordering issues

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2677/#review9183
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 15, 2013, 9:46 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2677/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22038
>     https://issues.asterisk.org/jira/browse/ASTERISK-22038
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The stasis_cache_update messages are somewhat cumbersome to handle
> with the stasis_message_router. Since all updates have the same
> message type, they are normally handled with the same route.
> 
> Since caching itself is a first class component of stasis-core, it
> makes sense for the router to handle the cache update messages itself.
> This patch adds stasis_message_router_add_cache_update() and
> stasis_message_router_remove_cache_update() to handle the routing of
> stasis_cache_update messages.
> 
> This patch also corrects an issue with manager_{bridging,channels}.c,
> where events might be reordered. The reordering occurs because the
> components use different message routers, which they needed because
> they both needed to route cache update messages. They now both use
> manager's router, and add cache routes for just the cache updates they
> are interested in.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_message_router.h 394397 
>   /trunk/main/cdr.c 394397 
>   /trunk/main/manager_bridging.c 394397 
>   /trunk/main/manager_channels.c 394397 
>   /trunk/main/stasis_message_router.c 394397 
>   /trunk/tests/test_stasis.c 394397 
> 
> Diff: https://reviewboard.asterisk.org/r/2677/diff/
> 
> 
> Testing
> -------
> 
> Unit tests! 
> 
> Note that https://reviewboard.asterisk.org/r/2675/ is required to fix
> assertions during the test.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130719/2c17f235/attachment.htm>