[asterisk-dev] [Code Review] 2658: Add transfer support to CEL

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2658/#review9181
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 15, 2013, 9:26 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2658/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21565
>     https://issues.asterisk.org/jira/browse/ASTERISK-21565
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds CEL support for blind and attended transfers and call pickup. During the course of adding this functionality I noticed that CONF_ENTER, CONF_EXIT, and BRIDGE_TO_CONF events are particularly useless without a bridge identifier, so I added that as well.
> 
> This adds tests for blind transfers, several types of attended transfers, and call pickup.
> 
> The extra field in CEL records now consists of a JSON blob whose fields are defined on a per-event basis.
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 394395 
>   trunk/apps/app_celgenuserevent.c 394395 
>   trunk/apps/app_dial.c 394395 
>   trunk/apps/app_directed_pickup.c 394395 
>   trunk/apps/app_queue.c 394395 
>   trunk/channels/chan_dahdi.c 394395 
>   trunk/channels/chan_sip.c 394395 
>   trunk/channels/sig_analog.c 394395 
>   trunk/include/asterisk/cel.h 394395 
>   trunk/main/cel.c 394395 
>   trunk/main/channel.c 394395 
>   trunk/main/features.c 394395 
>   trunk/main/pbx.c 394395 
>   trunk/tests/test_cel.c 394395 
> 
> Diff: https://reviewboard.asterisk.org/r/2658/diff/
> 
> 
> Testing
> -------
> 
> This passes all the CEL unit tests.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130719/00fffe44/attachment.htm>