[asterisk-dev] [Code Review] 2680: ARI: Channels - MOH start and stop

[jrose]

> On July 18, 2013, 2:17 p.m., Joshua Colp wrote:
> > /trunk/res/stasis/control.c, line 271
> > <https://reviewboard.asterisk.org/r/2680/diff/1/?file=41526#file41526line271>
> >
> >     This exposes an implementation detail of the caller here, free it there instead.
> 
> jrose wrote:
>     Oi, this is tricky. The caller is going to be a very generic command executor that works asynchronously from the provider of the data... and it doesn't currently take a desctructor of any kind. In retrospect, it really probably should.
> 
> Joshua Colp wrote:
>     Ah yeah, I keep forgetting the asyncness. It's fine then.

Oh, ok, well in that case, cool.

This does still strike me as an improvement that probably needs to be made at some point in time though in case we ever need to destroy a command in the command queue without actually executing it.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2680/#review9150
-----------------------------------------------------------


On July 16, 2013, 8:53 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2680/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 8:53 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21974
>     https://issues.asterisk.org/jira/browse/ASTERISK-21974
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This solves half of the issue.
> 
> mohStartChannel(channel, mohclass) - Play music on hold of the specified class to the requested channel. May be interrupted by other media requests such as playOnChannel.
> mohStop(channel) - Stop playing music on hold for the requested channel.
> 
> This patch is pretty simple, so I don't think there will be an issue with it.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 394458 
>   /trunk/res/res_stasis_http_channels.c 394458 
>   /trunk/res/stasis/control.c 394458 
>   /trunk/res/stasis_http/resource_channels.h 394458 
>   /trunk/res/stasis_http/resource_channels.c 394458 
>   /trunk/rest-api/api-docs/channels.json 394458 
> 
> Diff: https://reviewboard.asterisk.org/r/2680/diff/
> 
> 
> Testing
> -------
> 
> Started music on hold without the mohclass arg and with the mohclass arg. Observed how it would react if mohstart were used with one class and then switched to another. The music on hold would restart with the new class as anticipated.
> 
> Tested stop music on hold with and without music on hold playing. If it's playing, it stops as one would anticipate and if it's not playing, nothing happens. Nothing too irregular there.
> 
> Tested both of these operations while the channel is in a bridge. Didn't work. Oh no. Well, I talked with Matt about it after finding out the same thing happens with all media playback operations in ARI and he says this is a known bug outside the scope of this problem..
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130718/4b9f7db3/attachment-0001.htm>