[asterisk-dev] [Code Review] 2680: ARI: Channels - MOH start and stop

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2680/#review9150
-----------------------------------------------------------



/trunk/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2680/#comment18056>

    This is a paranoid check - you'll never have a non-NULL empty moh_class.



/trunk/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2680/#comment18055>

    This exposes an implementation detail of the caller here, free it there instead.



/trunk/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2680/#comment18054>

    I'm pretty sure you didn't mean to have an ast_strdup being used with ast_strlen_zero.


- Joshua Colp


On July 16, 2013, 8:53 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2680/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 8:53 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21974
>     https://issues.asterisk.org/jira/browse/ASTERISK-21974
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This solves half of the issue.
> 
> mohStartChannel(channel, mohclass) - Play music on hold of the specified class to the requested channel. May be interrupted by other media requests such as playOnChannel.
> mohStop(channel) - Stop playing music on hold for the requested channel.
> 
> This patch is pretty simple, so I don't think there will be an issue with it.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 394458 
>   /trunk/res/res_stasis_http_channels.c 394458 
>   /trunk/res/stasis/control.c 394458 
>   /trunk/res/stasis_http/resource_channels.h 394458 
>   /trunk/res/stasis_http/resource_channels.c 394458 
>   /trunk/rest-api/api-docs/channels.json 394458 
> 
> Diff: https://reviewboard.asterisk.org/r/2680/diff/
> 
> 
> Testing
> -------
> 
> Started music on hold without the mohclass arg and with the mohclass arg. Observed how it would react if mohstart were used with one class and then switched to another. The music on hold would restart with the new class as anticipated.
> 
> Tested stop music on hold with and without music on hold playing. If it's playing, it stops as one would anticipate and if it's not playing, nothing happens. Nothing too irregular there.
> 
> Tested both of these operations while the channel is in a bridge. Didn't work. Oh no. Well, I talked with Matt about it after finding out the same thing happens with all media playback operations in ARI and he says this is a known bug outside the scope of this problem..
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130718/477f9b3a/attachment-0001.htm>