[asterisk-dev] [Code Review] 2642: app_bridgewait: Add a name argument so that multiple holding bridges may be used

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2642/#review9139
-----------------------------------------------------------



/trunk/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2642/#comment18025>

    I think you should make the "This application will answer..." sentence a <note>.



/trunk/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2642/#comment18026>

    Destroy the bridge here to be sure of no bridge leaks.  Remember that ast_bridge_destroy() is not NULL safe.



/trunk/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2642/#comment18028>

    This does not need a lock.



/trunk/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2642/#comment18027>

    Since you pass the bridge reference to wait_bridge_wrapper_alloc(), you need to guarantee that the bridge is destroyed on failure.  As it is you have a potential bridge reference imbalance if the alloc fails.
    



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2642/#comment18024>

    Please start putting a blank line between variable declarations and subsequent code.  It makes locating declarations a little easier.


- rmudgett


On July 15, 2013, 8:40 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 8:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21922
>     https://issues.asterisk.org/jira/browse/ASTERISK-21922
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Previously the holding bridge used for bridgewait was a single bridge that once created would stick around until the application was unloaded.
> 
> Now things are a little more complicated. Each holding bridge has a name and will be destroyed when it is empty. Since it's theoretically possible to have channels enter a holding bridge without going through the bridge wait application, it isn't always possible to deliberately control when the bridge will be destroyed, so the bridge can effectively be abandoned and set to be destroyed once it empties out.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_bridgewait.c 394388 
>   /trunk/include/asterisk/bridging.h 394388 
>   /trunk/main/bridging.c 394388 
> 
> Diff: https://reviewboard.asterisk.org/r/2642/diff/
> 
> 
> Testing
> -------
> 
> Tested multiple simultaneous holding bridges, multiple channels in the same holding bridge, what would happen if one channel entered as another one was leaving but before the bridge was destroyed, tested bridges emptying out, tested module unload and module load after unload.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130716/5b0ba32d/attachment-0001.htm>