[asterisk-dev] [Code Review] 2254: add queue pause device states for queue member/queues

[Matt Jordan]

> On Jan. 17, 2013, 6:48 p.m., Alec Davis wrote:
> > I think the hint format should be Provider:queuename_queueattribute_agent
> >   Queue:403_pause_Local/xyz
> > 
> > This would be more inline with the Queue ringing hint;
> >   Queue:techsupport
> > 
> > Or the Queue_avail hint;
> >   Queue:techsupport_avail
> >
> 
> p_lindheimer wrote:
>     Can others familiar with 'proper state naming conventions' chime in now? I'm not picky but would like an 'authoritative' decision on the naming convention sooner rather then later. The FreePBX Distro includes this patch now in the Asterisk RPM and this format is incorporated into FreePBX 2.11 so if we need to make a change it would be nice to know in advance of any final approval of the patch itself. Thanks!
> 
> Mark Michelson wrote:
>     There's certainly no rules I can point you to on this one. In most cases, hint names have been pretty self-evident and haven't been conveying much information beyond a device name. In this case, as Alec has pointed out, it falls more in-line with other existing queue hints to have it laid out as he has recommended.

So, in the interest of not letting this die on the vine for 12, I propose the following:

* The hint names will be changed in this patch to follow the existing nomenclature of {queuename}_{hint_type}_{agent}. We'll document that this is the nomenclature used on the Asterisk wiki.
* Post this patch, that will bring us to the following device states:
** Queue:{queuename} - track ringing/not in use
** Queue:{queuename}_avail - track overall member availability for the queue (in use/not in use) - where members available is not in use
** Queue:{queuename}_pause_{member} - track member being paused/unpaused in a specific queue

If there's any objections, please let me know - otherwise I'll probably do the *very* minor clean up to the patch (remove C++ style comments) and commit this.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2254/#review7689
-----------------------------------------------------------


On Dec. 27, 2012, 12:46 p.m., p_lindheimer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2254/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 12:46 p.m.)
> 
> 
> Review request for Asterisk Developers and p_lindheimer.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add a Queue Pause Device State that allows hints to be generated and thus useful BLF buttons on phones. The format is:
> 
> qpause:qname:agent
> 
> so an example hint that could be made from this, for agent 702 (Local) in queue 434 would look like this:
> 
> exten => *46*702*434,hint,qpause:434:Local/702 at from-queue/n
> 
> This has been implemented in FreePBX 2.11 (currently in beta) and is required for full functionality, it has been tested using version 11 and 10 and the patch is included on the version of Asterisk included in the FreePBX Distro for both versions 10 and 11.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 378206 
> 
> Diff: https://reviewboard.asterisk.org/r/2254/diff/
> 
> 
> Testing
> -------
> 
> tested on latest versions 10 and 11 using FreePBX 2.11
> 
> 
> Thanks,
> 
> p_lindheimer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130716/9c8e477b/attachment.htm>