[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/#review9130
-----------------------------------------------------------



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2636/#comment18017>

    ast_channel_set_connected_line() merges connected with what is currently on the channel.  The decoded connected information could be a partial update.
    
    This is how the check should be done:
    
    res = connected_line_parse_data()
    if (!res) {
      ast_channel_connected_line_set(chan, &connected);
    }
    ast_party_connected_line_free()
    
    current_size = ast_connected_line_build_data(current, ast_channel_connected_indicated())
    proposed_size = ast_connected_line_build_data(proposed, ast_channel_connected())
    if (current_size == -1 || proposed_size == -1) {
      goto indicate_cleanup;
    }
    unchanged = !res && current_size == proposed_size && !memcmp(current, proposed, current_size)
    if (unchanged) {
      goto indicate_cleanup;
    }
    ast_party_connected_line_copy(ast_channel_connected_indicated(), ast_channel_connected())
    
    Please remember to wrap long lines at 90 columns.
    
    Also you have a redundant ast_channel_set_connected_line() call.


- rmudgett


On July 12, 2013, 3:46 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21829
>     https://issues.asterisk.org/jira/browse/ASTERISK-21829
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).
> 
> Old code which is no longer required has also been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 394183 
>   /trunk/main/bridging.c 394183 
>   /trunk/main/channel.c 394183 
>   /trunk/main/channel_internal_api.c 394183 
> 
> Diff: https://reviewboard.asterisk.org/r/2636/diff/
> 
> 
> Testing
> -------
> 
> Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).
> 
> Calling, transfers, etc.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130712/20f3357e/attachment-0001.htm>