[asterisk-dev] [Code Review] 2652: ARI: Add support for mute/unmute

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2652/#review9119
-----------------------------------------------------------



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2652/#comment17991>

    Minor nitpick - I'd enum 'em



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2652/#comment17994>

    I'll just comment here! You've got differing locking between these two functions. suppress locks, unsuppress does not. The callers also seemingly may or may not have the channel locked. You should decide on a locking policy and document it here, as well as implement it in the code.



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2652/#comment17992>

    Suppress passing of a frame type
    
    I wouldn't really call it stream :P


- Joshua Colp


On July 8, 2013, 8:55 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2652/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 8:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21618
>     https://issues.asterisk.org/jira/browse/ASTERISK-21618
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add support for muting and unmuting streams on a channel.
> 
> Mute has also been put into core, and used in res_mutestream.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 393847 
>   /trunk/include/asterisk/stasis_app.h 393847 
>   /trunk/main/channel.c 393847 
>   /trunk/res/res_mutestream.c 393847 
>   /trunk/res/stasis/control.c 393847 
>   /trunk/res/stasis_http/resource_channels.c 393847 
> 
> Diff: https://reviewboard.asterisk.org/r/2652/diff/
> 
> 
> Testing
> -------
> 
> Verified that only the proper stream direction gets muted/unmuted.  Also verified that muting multiple times will not require unmuting multiple times, and that unmuting multiple times does not cause issues.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130711/5a1e0cb8/attachment-0001.htm>