[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/#review9112
-----------------------------------------------------------



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17958>

    You need to init the struct, copy the connected info from chan_target, and clear the private id in the copy.
    
    The set_init routine uses the guide to set defaults of non-string values.  String values are set to NULL.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17959>

    You do not need to send a COLP update to an application.  Applications don't care about COLP.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17960>

    Unnecessary blank line change.
    



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2636/#comment17957>

    This will not work.
    
    For an interception routine, the change will always be blocked.  The interception routine must operate on the channel's copy of the connected line information.  When the routine is complete it ast_indicates the channels information to the channel driver.  This code is then going to see no change and block it.
    
    Unless the channel always keeps a copy of the last ast_indicated version lying around, the channel driver must filter out the duplicates.  Chan_dahdi already does this because it needs to keep a copy anyway.  Chan_sip should do this as well as chan_pjsip.


- rmudgett


On July 10, 2013, 4:25 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 4:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21829
>     https://issues.asterisk.org/jira/browse/ASTERISK-21829
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).
> 
> Old code which is no longer required has also been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridging.c 393869 
>   /trunk/main/channel.c 393869 
>   /trunk/include/asterisk/channel.h 393869 
> 
> Diff: https://reviewboard.asterisk.org/r/2636/diff/
> 
> 
> Testing
> -------
> 
> Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).
> 
> Calling, transfers, etc.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130710/20eda636/attachment-0001.htm>