[asterisk-dev] [Code Review] 2648: func_channel: set dtmf_features

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2648/#review9107
-----------------------------------------------------------



/trunk/main/bridging_basic.c
<https://reviewboard.asterisk.org/r/2648/#comment17942>

    This should not be indented.  reviewboard is doing something weird with the '#'.



/trunk/main/bridging_basic.c
<https://reviewboard.asterisk.org/r/2648/#comment17943>

    You could do this instead so the associations cannot get out of sync:
    static struct {
       char letter;
       unsigned int flag;
    } associations[] = {
       { 'T', REDIRECT },
    };
    
    Also you can use ARRAY_LEN() instead of the FEATURE_COUNT define.



/trunk/main/bridging_basic.c
<https://reviewboard.asterisk.org/r/2648/#comment17944>

    Another problem with this message is that it mentions CHANNEL(dtmf).  This function cannot know the context in which the caller called it.  Otherwise, it is so coupled to the caller that it might as well live in func_channel.c.


- rmudgett


On July 8, 2013, 3:59 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2648/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 3:59 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21876
>     https://issues.asterisk.org/jira/browse/ASTERISK-21876
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows setting dtmf features via a channel set function (namely CHANNEL(dtmf_features)
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_channel.c 393426 
>   /trunk/include/asterisk/bridging_basic.h 393426 
>   /trunk/main/bridging_basic.c 393426 
> 
> Diff: https://reviewboard.asterisk.org/r/2648/diff/
> 
> 
> Testing
> -------
> 
> Stuck two channels in the following extension:
> 
> exten => 10,1,NoOp
> exten => 10,n,Answer()
> exten => 10,n,Set(CHANNEL(dtmf_features)=wktx)
> exten => 10,n,Wait(50)
> 
> Then bridged them together with the manager bridge command and checked to see if both channels could park, transfer, and attended transfer.
> 
> It's worth noting that the dial application overrides this datastore entirely, so these don't get applied to dial as-is. This might need to be addressed.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130709/1b2b51bc/attachment.htm>