[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/#review9106
-----------------------------------------------------------



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17941>

    You could swap these two lines as a minor optimization.



/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17940>

    You might as well revert this check now.  It does nothing.  The macro/subroutine calls already have passed the COLP to the channel driver if they did not fail for some reason.
    
    This was not a good place to try and prevent unnecessary COLP updates.  The channel drivers should be doing this.


- rmudgett


On July 9, 2013, 5:03 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated July 9, 2013, 5:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21829
>     https://issues.asterisk.org/jira/browse/ASTERISK-21829
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).
> 
> Old code which is no longer required has also been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 393869 
>   /trunk/main/bridging.c 393869 
>   /trunk/main/channel.c 393869 
> 
> Diff: https://reviewboard.asterisk.org/r/2636/diff/
> 
> 
> Testing
> -------
> 
> Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).
> 
> Calling, transfers, etc.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130709/6a8b82a8/attachment-0001.htm>