[asterisk-dev] [Code Review] 2664: Change ARI user config to use a type field

Jason Parker reviewboard at asterisk.org
Tue Jul 9 13:33:39 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2664/#review9101
-----------------------------------------------------------

Ship it!


Ship It!

- Jason Parker


On July 8, 2013, 6:34 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2664/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 6:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When I initially wrote the configuration support for ARI users, I
> determined the section type by a category prefix (i.e., [user-admin]).
> 
> This is neither idiomatic Asterisk configuration, nor is it really
> that user friendly. This patch replaces the category prefix with a
> type field in the section, which is much cleaner.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/ari.conf.sample 393828 
>   /trunk/res/res_stasis_http.c 393828 
>   /trunk/res/stasis_http/config.c 393828 
> 
> Diff: https://reviewboard.asterisk.org/r/2664/diff/
> 
> 
> Testing
> -------
> 
> The config loads
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130709/3b589763/attachment.htm>


More information about the asterisk-dev mailing list