[asterisk-dev] [Code Review] 2642: app_bridgewait: Add a name argument so that multiple holding bridges may be used

[jrose]

> On July 6, 2013, 11:51 p.m., Matt Jordan wrote:
> > /trunk/apps/app_bridgewait.c, line 309
> > <https://reviewboard.asterisk.org/r/2642/diff/5/?file=41106#file41106line309>
> >
> >     You can simplify this somewhat by giving the container the only reference. If you successfully link the object in, drop the allocation reference.

Hmmmm, I don't like the practice of using a RAII_VAR with ao2_cleanup for the cleanup function to store a pointer instead of a reference. I think I'll make a cleanup function specific to the bridge wrappers to handle this.

While looking at this I noticed a couple of problems with how I was doing things anyway... like returning before cleaning up the bridge features.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2642/#review9086
-----------------------------------------------------------


On July 3, 2013, 4:40 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 4:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21922
>     https://issues.asterisk.org/jira/browse/ASTERISK-21922
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Previously the holding bridge used for bridgewait was a single bridge that once created would stick around until the application was unloaded.
> 
> Now things are a little more complicated. Each holding bridge has a name and will be destroyed when it is empty. Since it's theoretically possible to have channels enter a holding bridge without going through the bridge wait application, it isn't always possible to deliberately control when the bridge will be destroyed, so the bridge can effectively be abandoned and set to be destroyed once it empties out.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_bridgewait.c 393517 
>   /trunk/include/asterisk/bridging.h 393517 
>   /trunk/main/bridging.c 393517 
> 
> Diff: https://reviewboard.asterisk.org/r/2642/diff/
> 
> 
> Testing
> -------
> 
> Tested multiple simultaneous holding bridges, multiple channels in the same holding bridge, what would happen if one channel entered as another one was leaving but before the bridge was destroyed, tested bridges emptying out, tested module unload and module load after unload.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130708/c89bfe87/attachment.htm>