[asterisk-dev] [Code Review] 2656: res_parking: Apply ringing option on swap.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2656/#review9085
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 3, 2013, 7:17 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2656/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 7:17 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21877
>     https://issues.asterisk.org/jira/browse/ASTERISK-21877
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If ringing was set for the channel in parking and that channel gets swapped out for another channel (in the case of an attended transfer to Park with the 'r' option for example), then that ringing previously wasn't honored and the channel would just play music on hold as normal. This patch makes the swap event check if the ringing option was applied to the swapping channel's holding_participant role so that it can be applied with the rest of the options.
> 
> Also, error checking for bridge role application has been added.
> 
> Also noteworthy, I noticed that announcements would conflict with the ringing option and cause ringing to stop without being resumed. This is a bridging problem more than a parking problem and it has been noted in ASTERISK-22006 along with a proposed fix that I worked out with Richard.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridging.c 393530 
>   /trunk/res/parking/parking_bridge.c 393530 
>   /trunk/res/parking/parking_controller.c 393530 
>   /trunk/res/parking/res_parking.h 393530 
> 
> Diff: https://reviewboard.asterisk.org/r/2656/diff/
> 
> 
> Testing
> -------
> 
> Attended transfer to Park(,r)
> Finalized the transfer after hearing the announcement
> Parkee hears ringing afterwards.
> 
> I also probed at the bridge role options to make sure they were being applied.
> 
> Testing also revealed the issue with ast_bridge_channel_playfile and the ringing indication. This can cause ringing not to play if the call is transferred before the announcement is finished.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130706/9386737e/attachment-0001.htm>