[asterisk-dev] [Code Review] 2648: func_channel: set dtmf_features

[jrose]

> On July 3, 2013, 3:14 p.m., Mark Michelson wrote:
> > /trunk/bridges/bridge_builtin_features.c, line 736
> > <https://reviewboard.asterisk.org/r/2648/diff/3/?file=40980#file40980line736>
> >
> >     I don't understand the relevance of this change.

Oh, no relevance.  It just slipped in there while I was testing something.  Removing.


> On July 3, 2013, 3:14 p.m., Mark Michelson wrote:
> > /trunk/main/bridging_basic.c, lines 103-110
> > <https://reviewboard.asterisk.org/r/2648/diff/3/?file=40983#file40983line103>
> >
> >     This pattern is repeated five times in this function. This should be factored into its own function.

This actually isn't quite as easy to cleanly break out as it looks like it should be, but I'll do something about it to reduce code duplication at the very least.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2648/#review9062
-----------------------------------------------------------


On July 2, 2013, 7:05 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2648/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 7:05 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21876
>     https://issues.asterisk.org/jira/browse/ASTERISK-21876
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows setting dtmf features via a channel set function (namely CHANNEL(dtmf_features)
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_builtin_features.c 393426 
>   /trunk/funcs/func_channel.c 393426 
>   /trunk/include/asterisk/bridging_basic.h 393426 
>   /trunk/main/bridging_basic.c 393426 
> 
> Diff: https://reviewboard.asterisk.org/r/2648/diff/
> 
> 
> Testing
> -------
> 
> Stuck two channels in the following extension:
> 
> exten => 10,1,NoOp
> exten => 10,n,Answer()
> exten => 10,n,Set(CHANNEL(dtmf_features)=wktx)
> exten => 10,n,Wait(50)
> 
> Then bridged them together with the manager bridge command and checked to see if both channels could park, transfer, and attended transfer.
> 
> It's worth noting that the dial application overrides this datastore entirely, so these don't get applied to dial as-is. This might need to be addressed.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/6bf5a072/attachment.htm>