[asterisk-dev] [Code Review] 2655: OneTouchRecord: Make so Monitor/MixMonitor can be toggled/started/stopped.

[Mark Michelson]

> On July 3, 2013, 7:29 p.m., Mark Michelson wrote:
> > As far as changes here are concerned, things look fine.
> > 
> > What concerns me is the fact that one-touch recording is disabled if the bridge peer cannot be determined. The only thing the bridge peer is used for is for help in naming the audio files saved during one-touch recording (and even then, possibly not due to configuration). It seems odd that recording would be completely disabled if the bridge peer cannot be determined.

Ignore this comment. I deleted it before publishing my review, but reviewboard decided to post it anyway.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2655/#review9070
-----------------------------------------------------------


On July 3, 2013, 5:18 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2655/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 5:18 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The OneTouchRecord feature has historically been a toggle.  This patch adds the ability to make the OneTouchRecord hook optionally start/stop recording only.  If OneTouchRecord is already doing what is requested then only the invoker hears the courtesy tone and/or start/stop recording message.
> 
> The new feature is written so it we could easily add explicit start/stop recording DTMF hooks for Monitor and MixMonitor.
> 
> The majority of the changes in bridge_builtin_features.c is a refactoring of the OneTouchRecord code (Monitor and MixMonitor versions) so it is easy to direct the toggle/start/stop functionality.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_builtin_features.c 393531 
>   /trunk/include/asterisk/bridging_features.h 393531 
> 
> Diff: https://reviewboard.asterisk.org/r/2655/diff/
> 
> 
> Testing
> -------
> 
> Tested with the chan_agent replacement functionality project.  I was able to start recording when the agent connected with a caller and I was able to fake starting a recording if it was already started before the agent connected with a caller.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/ee37d2b4/attachment-0001.htm>