[asterisk-dev] [Code Review] 2655: OneTouchRecord: Make so Monitor/MixMonitor can be toggled/started/stopped.

rmudgett reviewboard at asterisk.org
Wed Jul 3 12:18:37 CDT 2013

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers and Matt Jordan.

Repository: Asterisk


The OneTouchRecord feature has historically been a toggle.  This patch adds the ability to make the OneTouchRecord hook optionally start/stop recording only.  If OneTouchRecord is already doing what is requested then only the invoker hears the courtesy tone and/or start/stop recording message.

The new feature is written so it we could easily add explicit start/stop recording DTMF hooks for Monitor and MixMonitor.

The majority of the changes in bridge_builtin_features.c is a refactoring of the OneTouchRecord code (Monitor and MixMonitor versions) so it is easy to direct the toggle/start/stop functionality.


  /trunk/bridges/bridge_builtin_features.c 393531 
  /trunk/include/asterisk/bridging_features.h 393531 

Diff: https://reviewboard.asterisk.org/r/2655/diff/


Tested with the chan_agent replacement functionality project.  I was able to start recording when the agent connected with a caller and I was able to fake starting a recording if it was already started before the agent connected with a caller.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/1b9330ca/attachment.htm>

More information about the asterisk-dev mailing list