[asterisk-dev] [Code Review] 2652: ARI: Add support for mute/unmute

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2652/#review9067
-----------------------------------------------------------



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2652/#comment17810>

    I think we should take the chance to rename this to what it actually does.
    
    Muting I would expect to replace the media with silence.
    
    In this case what's really happening is that a specific frame type is being suppressed.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2652/#comment17811>

    Why can't you make direction a bitmask and reduce things to a single datastore?



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2652/#comment17812>

    Can you make mute_data a reference counted object shared between both the framehook and datastore? I think it would clean stuff up a bit.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2652/#comment17804>

    WARNING



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2652/#comment17805>

    WARNING



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2652/#comment17806>

    WARNING



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2652/#comment17807>

    WARNING



/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2652/#comment17813>

    If you went down the bitmask route it would also simplify this a little bit and reduce the code, same for unmute.


- Joshua Colp


On July 2, 2013, 4:37 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2652/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21618
>     https://issues.asterisk.org/jira/browse/ASTERISK-21618
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add support for muting and unmuting streams on a channel.
> 
> Mute has also been put into core, and used in res_mutestream.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 393440 
>   /trunk/include/asterisk/channel.h 393440 
>   /trunk/main/channel.c 393440 
>   /trunk/res/res_mutestream.c 393440 
>   /trunk/res/stasis/control.c 393440 
>   /trunk/res/stasis_http/resource_channels.c 393440 
> 
> Diff: https://reviewboard.asterisk.org/r/2652/diff/
> 
> 
> Testing
> -------
> 
> Verified that only the proper stream direction gets muted/unmuted.  Also verified that muting multiple times will not require unmuting multiple times, and that unmuting multiple times does not cause issues.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/66e35b31/attachment-0001.htm>