[asterisk-dev] [Code Review] 2642: app_bridgewait: Add a name argument so that multiple holding bridges may be used

jrose reviewboard at asterisk.org
Wed Jul 3 11:08:24 CDT 2013



> On July 3, 2013, 2:02 p.m., Mark Michelson wrote:
> > /trunk/apps/app_bridgewait.c, lines 59-61
> > <https://reviewboard.asterisk.org/r/2642/diff/4/?file=41076#file41076line59>
> >
> >     The second sentence is a bit awkward. I understand the part about "for app_bridgewait purposes only" but I don't know what you had in mind by mentioning "does not reflect properties of the bridges created" .

Oh, what I meant was that the bridge itself has no reference of any kind to the name assigned to the holding bridge in this scenario. I'll rewrite this to be a little more self explanatory:

	Name of the holding bridge to join. This is a handle for app_bridgewait
	only and does not affect the actual bridges that are created. If not provided,
	the reserved name <literal>default</literal> will be used.


> On July 3, 2013, 2:02 p.m., Mark Michelson wrote:
> > /trunk/main/bridging.c, line 3009
> > <https://reviewboard.asterisk.org/r/2642/diff/4/?file=41078#file41078line3009>
> >
> >     It's typically a good idea not to assume what the integer values of enums are. This should be explicitly comparing to BRIDGE_CHANNEL_PUSH_SUCCESS.

I also forgot the breaks in the switch statement below.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2642/#review9056
-----------------------------------------------------------


On July 2, 2013, 10:57 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2642/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 10:57 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21922
>     https://issues.asterisk.org/jira/browse/ASTERISK-21922
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Previously the holding bridge used for bridgewait was a single bridge that once created would stick around until the application was unloaded.
> 
> Now things are a little more complicated. Each holding bridge has a name and will be destroyed when it is empty. Since it's theoretically possible to have channels enter a holding bridge without going through the bridge wait application, it isn't always possible to deliberately control when the bridge will be destroyed, so the bridge can effectively be abandoned and set to be destroyed once it empties out.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_bridgewait.c 393517 
>   /trunk/include/asterisk/bridging.h 393517 
>   /trunk/main/bridging.c 393517 
> 
> Diff: https://reviewboard.asterisk.org/r/2642/diff/
> 
> 
> Testing
> -------
> 
> Tested multiple simultaneous holding bridges, multiple channels in the same holding bridge, what would happen if one channel entered as another one was leaving but before the bridge was destroyed, tested bridges emptying out, tested module unload and module load after unload.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/35536eff/attachment.htm>


More information about the asterisk-dev mailing list