[asterisk-dev] [Code Review] 2653: Add some Local channel tests

Matt Jordan reviewboard at asterisk.org
Wed Jul 3 10:36:17 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2653/
-----------------------------------------------------------

(Updated July 3, 2013, 3:36 p.m.)


Review request for Asterisk Developers.


Changes
-------

Forgot to add the local_optimize_away python script - whoops. Updated!


Repository: testsuite


Description
-------

This patch adds four tests for Local channels to the Test Suite:

* A test that originates an optimizing Local channel, connects it to a SIP channel and executes an application. The test verifies that we don't optimize (yes, this is "impossible" currently, but it's good to check that)
* A test that originates both an optimizing and non-optimizing Local channel between two SIP channels in basic mixing bridges and verifies both that an optimization occurs when it should and that it doesn't when it shouldn't
* A test that originates both an optimizing and non-optimizing Local channel between a SIP channel and a holding bridge. The test verifies that we optimize when we should and don't optimize when we shouldn't.
* A test that originates a non-optimizing Local channel between two SIP channels and then forces an optimization via the LocalOptimizeAway AMI action.


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/local/local_app/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_app/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_app/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_call/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_call/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_call/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_holding_bridge/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_holding_bridge/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_holding_bridge/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_optimize_away/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_optimize_away/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_optimize_away/local_optimize_away.py PRE-CREATION 
  /asterisk/trunk/tests/channels/local/local_optimize_away/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/local/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/tests.yaml 3839 

Diff: https://reviewboard.asterisk.org/r/2653/diff/


Testing
-------

Things pass!


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/0e9c215c/attachment.htm>


More information about the asterisk-dev mailing list