[asterisk-dev] [Code Review] 2641: ARI: Add support for getting/setting channel and global variables.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2641/#review9058
-----------------------------------------------------------

Ship it!



/trunk/res/res_stasis_http_asterisk.c
<https://reviewboard.asterisk.org/r/2641/#comment17798>

    This is not an official critique, but,
    
    *barf*



/trunk/res/res_stasis_http_asterisk.c
<https://reviewboard.asterisk.org/r/2641/#comment17796>

    Coding guidelines:
    Place the if on the same line as the preceding else.


- Mark Michelson


On July 2, 2013, 9:12 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2641/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 9:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21868
>     https://issues.asterisk.org/jira/browse/ASTERISK-21868
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows for reading channel variables (or functions), setting channel variables (or functions), getting global variables, setting global variables.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 393487 
>   /trunk/res/res_stasis_http_asterisk.c 393487 
>   /trunk/res/res_stasis_http_channels.c 393487 
>   /trunk/res/stasis/control.c 393487 
>   /trunk/res/stasis_http/resource_asterisk.h 393487 
>   /trunk/res/stasis_http/resource_asterisk.c 393487 
>   /trunk/res/stasis_http/resource_channels.h 393487 
>   /trunk/res/stasis_http/resource_channels.c 393487 
>   /trunk/res/stasis_json/resource_asterisk.h 393487 
>   /trunk/res/stasis_json/resource_channels.h 393487 
>   /trunk/rest-api/api-docs/asterisk.json 393487 
>   /trunk/rest-api/api-docs/channels.json 393487 
> 
> Diff: https://reviewboard.asterisk.org/r/2641/diff/
> 
> 
> Testing
> -------
> 
> All 4 things work.  Failures occur in the few places they would be expected (invalid function name, etc).
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/53f77078/attachment.htm>