[asterisk-dev] [Code Review] 2645: Use stasis cache in more places

[opticron]

> On June 27, 2013, 12:37 p.m., opticron wrote:
> > /trunk/main/manager_channels.c, line 522
> > <https://reviewboard.asterisk.org/r/2645/diff/2/?file=40430#file40430line522>
> >
> >     Be warned that changing this function means updating a hefty amount of XML documentation.
> >     
> >     For the use case in this review, it's perfectly acceptable to use this function unmodified and add more parameters from the snapshot on a case-by-case basis.
> 
> Joshua Colp wrote:
>     I purposely did it this way to ensure that we don't get into a situation where a consumer would have to query to get additional information that may be useful. If the masses disagree, I'm fine with doing as you say.
>     
>     I did document things though.

You documented the non-prefixed case which, unfortunately, does not automatically propagate to all variants of the channel snapshot AMI blob. There are currently 14 prefixed variants of the channel snapshot XML documentation including: Target, LocalOne, LocalTwo, Transferer, OrigTransferer, SecondTransferer, a second LocalOne, a second LocalTwo, Dest, Spyer, Spyee, Parkee, Parker, and Retriever. I'm going to spend some time with XSLT this weekend to see what I can do about this problem.

This also applies to the bridge AMI blob changes, though it doesn't have nearly that many variants.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2645/#review8998
-----------------------------------------------------------


On July 2, 2013, 6:04 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2645/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 6:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21883
>     https://issues.asterisk.org/jira/browse/ASTERISK-21883
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves CLI/AGI/AMI commands to accessing the Stasis cache for retrieving information instead of directly accessing the data structures. I have also added an AMI action to get bridge information, and extended the "status" action to include the same information available as "core show channel".
> 
> Stuff given up:
> 1. Number of frames being read and written
> 2. First file descriptor
> 3. What the channel is blocked in
> 
> An additional question:
> I'm not currently storing channel trace information in the snapshot and as a result it is not displayed. Is this a feature we still want to support? How widespread is it?
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 393517 
>   /trunk/include/asterisk/stasis_channels.h 393517 
>   /trunk/main/bridging.c 393517 
>   /trunk/main/channel.c 393517 
>   /trunk/main/channel_internal_api.c 393517 
>   /trunk/main/cli.c 393517 
>   /trunk/main/manager.c 393517 
>   /trunk/main/manager_bridging.c 393517 
>   /trunk/main/manager_channels.c 393517 
>   /trunk/main/pbx.c 393517 
>   /trunk/main/stasis_channels.c 393517 
>   /trunk/res/res_agi.c 393517 
> 
> Diff: https://reviewboard.asterisk.org/r/2645/diff/
> 
> 
> Testing
> -------
> 
> Executed the changed CLI commands, AMI actions, and AGI commands and ensured that the output is as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130703/4b33300d/attachment-0001.htm>