[asterisk-dev] [Code Review] 2552: Add local channel Stasis-Core messages and AMI events

[Matt Jordan]

> On June 7, 2013, 1:35 a.m., rmudgett wrote:
> > /team/group/bridge_construction/main/core_unreal.c, lines 282-308
> > <https://reviewboard.asterisk.org/r/2552/diff/1/?file=38314#file38314line282>
> >
> >     Don't put the optimize events here.  You will flood the system with events for every media frame.
> >     
> >     You have to push the calls to the callbacks deeper into ast_bridge_unreal_optimized_out() where it decides to attempt optimization and where it finds out it succeeded or not.

Wellll.... it wouldn't have flooded the system with optimization begun messages, as the AST_UNREAL_OPTIMIZE_BEGUN flag will prevent that. But it's still the wrong place.

Moved into the bridging core where it *knows* that the optimization has started and finished.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2552/#review8857
-----------------------------------------------------------


On May 20, 2013, 2:32 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2552/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 2:32 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch does the following:
> 
> * It adds a virtual table of callbacks to core_unreal. These callbacks can be supplied by concrete implementations of "unreal" channel drivers, which lets the unreal channel driver call specific functionality when it performs some action. Currently, this is done to notify implementations when an optimization operation has begun, and when an optimization operation has succeeded.
> 
> * It adds Stasis-Core messages for Local channel bridging and Local channel optimization. Local channel optimization is now two events: a Begin and an End. Some consumers of Stasis-Core may want to know when an operation is beginning so that they can 'prepare' their information; others will be more concerned about when the operation has completed, so that they can 'fix up' information. Stasis-Core allows for both, as does AMI.
> 
> * It also includes a memory leak fix in dial messages.
> 
> Note that the documentation included with this patch assumes that the AMI events will be turned into prefixes, as other reviews have already made this change.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/CHANGES 389195 
>   /team/group/bridge_construction/include/asterisk/core_local.h 389195 
>   /team/group/bridge_construction/include/asterisk/core_unreal.h 389195 
>   /team/group/bridge_construction/main/asterisk.c 389195 
>   /team/group/bridge_construction/main/core_local.c 389195 
>   /team/group/bridge_construction/main/core_unreal.c 389195 
>   /team/group/bridge_construction/main/manager_channels.c 389195 
>   /team/group/bridge_construction/main/stasis_channels.c 389195 
> 
> Diff: https://reviewboard.asterisk.org/r/2552/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130702/e0444803/attachment-0001.htm>