[asterisk-dev] [Code Review] 2648: func_channel: set dtmf_features

[jrose]

> On July 2, 2013, 3:24 a.m., Matt Jordan wrote:
> > /trunk/funcs/func_channel.c, lines 107-108
> > <https://reviewboard.asterisk.org/r/2648/diff/2/?file=40756#file40756line107>
> >
> >     Didn't we agree that these should be uppercase, since they are applied to the channel calling the function and not the peer?

They are, I just forgot to change the documentation for the individual characters. It even says 'The features string must be all upper case.' in that block you quoted :P


> On July 2, 2013, 3:24 a.m., Matt Jordan wrote:
> > /trunk/funcs/func_channel.c, lines 105-109
> > <https://reviewboard.asterisk.org/r/2648/diff/2/?file=40756#file40756line105>
> >
> >     Why wouldn't this be R/W?
> >     
> >     It may be useful to know what features have been applied to a channel.

For some reason I was just under the impression they were write only.  I'm not sure if I asked you about it or what.

Regardless, fixed.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2648/#review9040
-----------------------------------------------------------


On July 1, 2013, 2:41 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2648/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 2:41 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21876
>     https://issues.asterisk.org/jira/browse/ASTERISK-21876
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows setting dtmf features via a channel set function (namely CHANNEL(dtmf_features)
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_channel.c 393154 
>   /trunk/include/asterisk/bridging_basic.h 393154 
>   /trunk/main/bridging_basic.c 393154 
> 
> Diff: https://reviewboard.asterisk.org/r/2648/diff/
> 
> 
> Testing
> -------
> 
> Stuck two channels in the following extension:
> 
> exten => 10,1,NoOp
> exten => 10,n,Answer()
> exten => 10,n,Set(CHANNEL(dtmf_features)=wktx)
> exten => 10,n,Wait(50)
> 
> Then bridged them together with the manager bridge command and checked to see if both channels could park, transfer, and attended transfer.
> 
> It's worth noting that the dial application overrides this datastore entirely, so these don't get applied to dial as-is. This might need to be addressed.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130702/c4336fd2/attachment.htm>