[asterisk-dev] [Code Review] 2650: Testsuite - ARI Authentication Tests

Matt Jordan reviewboard at asterisk.org
Mon Jul 1 19:06:21 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2650/#review9038
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On June 28, 2013, 2:56 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2650/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 2:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21277
>     https://issues.asterisk.org/jira/browse/ASTERISK-21277
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds a test to validate authentication for ARI. It also
> modifies the ARI support to take authentication into account.
> 
> This is fundamentally a data driven test, in which a number of
> scenarios are executed (execute this method on this URL with this
> username and password), and the actual response is validated against
> the expected response.
> 
> Both HTTP authentication and ?api_key authentication are tested with
> each scenario.
> 
> See https://reviewboard.asterisk.org/r/2649 for the patch that adds
> authentication to ARI.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/ari.py 3876 
>   /asterisk/trunk/tests/rest_api/authentication/configs/ast1/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/authentication/configs/ast1/stasis_http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/authentication/run-test PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/authentication/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/continue/configs/ast1/stasis_http.conf 3876 
>   /asterisk/trunk/tests/rest_api/tests.yaml 3876 
> 
> Diff: https://reviewboard.asterisk.org/r/2650/diff/
> 
> 
> Testing
> -------
> 
> Tests pass
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130702/32ee2a4e/attachment.htm>


More information about the asterisk-dev mailing list