[asterisk-dev] [Code Review] 2633: Filter channels used as internal mechanisms

[Matt Jordan]

> On June 25, 2013, 6:27 p.m., Matt Jordan wrote:
> > trunk/apps/confbridge/conf_chan_announce.c, lines 118-127
> > <https://reviewboard.asterisk.org/r/2633/diff/3/?file=39951#file39951line118>
> >
> >     While we're here...
> >     
> >     We should probably rename this to be more reflective of its actual purpose. Yes, ConfBridge is what uses it currently, but other things will as well.
> >     
> >     How about just "Bridge Announcer Channel"?
> 
> rmudgett wrote:
>     Matt:
>     CBAnn and CBRec are specific to ConfBridge and their implementation reflects this.  At this time, changing the names is not good.
> 
> opticron wrote:
>     My concern here was that ConfBridge's announcer and recorder channels may not be the same as the bridging framework's announcer and recorder channels (at least in the near term) and that it would be prudent to be able to differentiate between them.

That's fine, but these aren't going to be used by just ConfBridge for much longer, at which point in time these are going to get renamed anyway.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2633/#review8968
-----------------------------------------------------------


On June 21, 2013, 12:56 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2633/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 12:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21873
>     https://issues.asterisk.org/jira/browse/ASTERISK-21873
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds a new function pointer to the channel tech which determines whether a channel is fit for external consumption. Examples of channels that would not be fit for external consumption include the announcement and recording channels used by confbridge which are the only two marked as such by this patch.
> 
> A lot of this ended up being cleanup to ensure callers of various functions could handle a NULL return.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/confbridge/conf_chan_announce.c 392407 
>   trunk/apps/confbridge/conf_chan_record.c 392407 
>   trunk/apps/confbridge/confbridge_manager.c 392407 
>   trunk/include/asterisk/channel.h 392407 
>   trunk/include/asterisk/stasis_channels.h 392407 
>   trunk/main/cdr.c 392407 
>   trunk/main/cel.c 392407 
>   trunk/main/manager_bridging.c 392407 
>   trunk/main/manager_channels.c 392407 
>   trunk/main/stasis_channels.c 392407 
>   trunk/res/parking/parking_manager.c 392407 
> 
> Diff: https://reviewboard.asterisk.org/r/2633/diff/
> 
> 
> Testing
> -------
> 
> Ran through CDR unit tests.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130701/0d88eb25/attachment.htm>