[asterisk-dev] [Code Review] 2554: Pimp my SIP: alwaysauthreject

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2554/#review9028
-----------------------------------------------------------


A few files in the latest review don't apply cleanly. You might need to resolve the conflicts with them and update the review.

- Matt Jordan


On June 14, 2013, 7:15 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2554/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 7:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21433
>     https://issues.asterisk.org/jira/browse/ASTERISK-21433
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds support for 'alwaysauthreject' to the new SIP channel driver.  When the 'alwaysauthreject' option is set to 'yes' (default) and no matching endpoint is found for the incoming request, after challenging, Asterisk will respond with a 401 Unauthorized regardless of the reason it rejects the request.
> 
> These changes also include a new global 'security' configuration section in res_sip.conf that now includes the 'alwaysauthreject' and ACL options.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/res/res_sip/config_security.c PRE-CREATION 
>   team/group/pimp_my_sip/res/res_sip/config_auth.c 391863 
>   team/group/pimp_my_sip/res/res_sip.exports.in 391863 
>   team/group/pimp_my_sip/res/res_sip.c 391863 
>   team/group/pimp_my_sip/include/asterisk/res_sip.h 391863 
>   team/group/pimp_my_sip/res/res_sip/sip_configuration.c 391863 
>   team/group/pimp_my_sip/res/res_sip/sip_distributor.c 391863 
>   team/group/pimp_my_sip/res/res_sip_acl.c 391863 
>   team/group/pimp_my_sip/res/res_sip_authenticator_digest.c 391863 
>   team/group/pimp_my_sip/res/res_sip_outbound_authenticator_digest.c 391863 
> 
> Diff: https://reviewboard.asterisk.org/r/2554/diff/
> 
> 
> Testing
> -------
> 
> Attempted to connect to an unknown endpoint in Asterisk and observed that it responded appropriately and with a correct 401 when 'alwaysauthreject' was enabled.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130701/50cfe22c/attachment.htm>