[asterisk-dev] [Code Review] 2643: Stasis - Refactor AOC Events

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2643/
-----------------------------------------------------------

(Updated July 1, 2013, 8:13 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review findings.


Bugs: ASTERISK-21472
    https://issues.asterisk.org/jira/browse/ASTERISK-21472


Repository: Asterisk


Description
-------

Refactored the AMI events in AOC onto Stasis-Core.  The ast_aoc_manager_event function now publishes a channel snapshot, along with a JSON blob describing the advice of charge.  A "to_ami" handler has also been added that converts the channel snapshot and AOC event data back into the appropriate data structure for use with AMI.


Diffs (updated)
-----

  ./trunk/main/aoc.c 393352 
  ./trunk/main/manager.c 393352 

Diff: https://reviewboard.asterisk.org/r/2643/diff/


Testing
-------

This one is kind of hard to actually test.  However, I did create a temporary AMI command in order to push data into the ast_aoc_manager_event function in order to verify the values were properly being converted between data structures, JSON, and string values.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130701/62e9df4a/attachment.htm>