[asterisk-dev] Opus and VP8

[Tzafrir Cohen]

On Mon, May 27, 2013 at 09:35:21PM +0200, Lorenzo Miniero wrote:
> 2013/5/27 Tzafrir Cohen <tzafrir.cohen at xorcom.com>
> 
> > On Mon, May 27, 2013 at 04:09:08PM +0200, Lorenzo Miniero wrote:
> > > Dear all,
> > >
> > > I've just published the patch on github:
> > >
> > > https://github.com/meetecho/asterisk-opus
> > >
> > > The README should be quite self explainatory, but if you need any
> > > additional info feel free to ask me.
> > > Any feedback will be more than welcome!
> >
> > $ diffstat asterisk-opus/asterisk_opus+vp8.diff
> >  build_tools/menuselect-deps.in |    1
> >  channels/chan_sip.c            |   91 ++++++-
> >  codecs/codec_opus.c            |  529
> > +++++++++++++++++++++++++++++++++++++++++
> >  codecs/ex_opus.h               |   35 ++
> >  configure.ac                   |    3
> >  formats/format_vp8.c           |  195 +++++++++++++++
> >  include/asterisk/format.h      |    4
> >  main/channel.c                 |    2
> >  main/format.c                  |   16 +
> >  main/frame.c                   |   38 ++
> >  main/rtp_engine.c              |    6
> >  makeopts.in                    |    3
> >  res/res_rtp_asterisk.c         |   42 +++
> >  13 files changed, 960 insertions(+), 5 deletions(-)
> >
> > Any problem with including the format parts of this patch into Asterisk?
> > Asterisk has limited support for H.264 video. I don't suppose Asterisk
> > comes with a license for a H.264 video playback (let alone encoding).
> >
> > At first glance, the following parts of the patch seem to be related to
> > formats, rather than codecs:
> >
> >  channels/chan_sip.c            |   91 ++++++-
> >  formats/format_vp8.c           |  195 +++++++++++++++
> >  include/asterisk/format.h      |    4
> >  main/channel.c                 |    2
> >  main/format.c                  |   16 +
> >  main/rtp_engine.c              |    6
> >  res/res_rtp_asterisk.c         |   42 +++
> >
> > Would a patch / review of those parts by Lorenzo be welcomed?
> >
> >
> 
> Actually all the files have stuff related to both codecs: so the code
> related to Opus should be stripped from chan_sip, format, rtp_engine, etc.
> first in order to have them refer to VP8 only. The format_vp8.c file itself
> is pretty much a clone of the H.264 one, so if this one's ok I guess that
> one will be too.

In case I was not clear enough: I believe (and I suppose Matt's answer
clarified it) that those parts of the patch can be merged into Asterisk
as there's no reasonable fear of abusing any patents with them.

If you agree with me, please follow up with the bug I opened:
https://issues.asterisk.org/jira/browse/ASTERISK-21981
and attach the partial patch.

The nice thing about it is that it includes almost all of the patching
needed to actual Asterisk code (besides the changes to frame.c . I
wonder if those are actually needed). Apart from that you only have
codec modules and changes to the build system required to build them.

(if this bug is a duplicate: sorry for the noise. I didn't see any
progress here)

If this is to be merged before the Asterisk 12 freeze, we don't have
much time.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com