[asterisk-dev] [Code Review] Re-work building of pjproject

Jason Parker reviewboard at asterisk.org
Thu Jan 31 15:51:28 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 31, 2013, 3:51 p.m.)

Review request for Asterisk Developers.


Address (maybe) Walter's comments about configure scripts on clean/dist-clean.


This review depends on the changes from https://reviewboard.asterisk.org/r/2291/

This changes the way we build pjproject.  We no longer need to execute the top-level 'all' target.  We can build individual libraries instead.

We should now be much more tolerant of build failures along the way.

Incidentally, in order to properly fix one of the major issues people were facing, I had to change our top-level Makefile to clean our own broken dependencies.  Targets that need configure to have been run should now actually require configure to have been run.

Also removes a few weird workarounds that got added along the way.

This addresses bug ASTERISK-20815.

Diffs (updated)

  /branches/11/Makefile 380737 
  /branches/11/res/Makefile 380737 
  /branches/11/res/pjproject/aconfigure 380737 
  /branches/11/res/pjproject/aconfigure.ac 380737 
  /branches/11/res/pjproject/build/common.mak 380737 
  /branches/11/res/pjproject/build/os-auto.mak.in 380737 

Diff: https://reviewboard.asterisk.org/r/2292/diff


Many, many builds, in varying states of completeness and cleanliness.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130131/d18207ba/attachment.htm>

More information about the asterisk-dev mailing list