[asterisk-dev] [Code Review]: Adds variable length callinfo packets to skinny
wedhorn
reviewboard at asterisk.org
Thu Jan 31 15:29:01 CST 2013
> On Jan. 31, 2013, 3:12 p.m., opticron wrote:
> > /trunk/channels/chan_skinny.c, line 2437
> > <https://reviewboard.asterisk.org/r/2290/diff/3/?file=33095#file33095line2437>
> >
> > You may want to mask this instead of using multiplication and division so it's a little more clear that the two lower bits are being cleared.
This is used to prune the packet, not clear the last 2 bits. Original struct has char[256], this makes sure we only put as much of the char[256] on the wire as has data (rounded up to the next 4th byte).
- wedhorn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2290/#review7785
-----------------------------------------------------------
On Jan. 25, 2013, 1:16 p.m., wedhorn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2290/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 1:16 p.m.)
>
>
> Review request for Asterisk Developers and Brad Latus.
>
>
> Summary
> -------
>
> Add packet 0x014A (variable length call info messages) to skinny for newer firmware. Plenty of unknown information but includes the equivalent functionality as the fixed size callinfo packet already included.
>
> Only send this packet if protocol reported is >= 17.
>
>
> This addresses bug ASTERISK-20965.
> https://issues.asterisk.org/jira/browse/ASTERISK-20965
>
>
> Diffs
> -----
>
> /trunk/channels/chan_skinny.c 380057
>
> Diff: https://reviewboard.asterisk.org/r/2290/diff
>
>
> Testing
> -------
>
> Made in/out/missed calls on v17 phone, correct info displayed on call and on device call logs. Checked that the old callinfo is still used when protocol is <17.
>
>
> Thanks,
>
> wedhorn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130131/04008960/attachment.htm>
More information about the asterisk-dev
mailing list