[asterisk-dev] [Code Review]: testsuite: Fail Tokens

[jrose]

> On Jan. 30, 2013, 9:31 a.m., jrose wrote:
> > /asterisk/trunk/lib/python/asterisk/TestCase.py, lines 499-500
> > <https://reviewboard.asterisk.org/r/2302/diff/1/?file=33186#file33186line499>
> >
> >     This function could stand to be a little smarter I think.  I'll go ahead and automatically set the test to failed if an attempt is made to remove a fail token that isn't in the list.  I'm pretty sure that could cause an error anyway.

replaced with:

    def remove_fail_token(self, fail_token):
        if not fail_token in self.fail_tokens:
            logger.error("Attempted to remove a fail token that isn't in the fail tokens list\n"
                         "    => '%s'\n"
                         "    This fail token was probably already removed." % fail_token['message'])
            self.passed = False
            return

        self.fail_tokens.remove(fail_token)


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2302/#review7772
-----------------------------------------------------------


On Jan. 29, 2013, 4:40 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2302/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 4:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, Matt Jordan, and kmoore.
> 
> 
> Summary
> -------
> 
> I was flustered when I found out that the pass/failure state was shared between all test modules in a test and setting pass in a single module means you have to actively get failures in every other module in order for the test to fail, so I came up with this interesting little fix.
> 
> Test objects now contain a fail tokens list.  In order to add to this list, the function 'create_fail_token(message)' should be used. When called, this will create a new fail token with a UUID and the message contained and automatically add it to the fail token list. It will return a reference to that fail_token, which should be kept by its issuer so that it can be cleared later.
> 
> If any fail tokens exist in the stack when the overall pass/failure of the test is being evaluated, the test will automatically indicate failure while logging the failure message given to the create_fail_token function that created it.
> 
> Tokens are removed from the list with the remove_fail_token(failtoken) function (which is where the value returned from create_fail_token should be supplied).
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/TestCase.py 3617 
> 
> Diff: https://reviewboard.asterisk.org/r/2302/diff
> 
> 
> Testing
> -------
> 
> I added a few fail tokens to my callparking_timeout/comebacktoorigin_no test and observed what would happen if I cleared none, any one, a subset of them, and all of them.  In every case the right failtoken(s) were cleared and the remaining fail tokens would cause failures to occur with the right messages logged. If no fail tokens were left over, the test would pass provided that the test didn't set failure elsewhere.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130130/e0f2a73e/attachment.htm>