[asterisk-dev] [Code Review] Correct the number of available call numbers in IAX2

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2293/#review7761
-----------------------------------------------------------

Ship it!


This looks OK now.  Just a minor comment correction.


/trunk/channels/iax2.h
<https://reviewboard.asterisk.org/r/2293/#comment14750>

    This statement is not quite true.  How about this instead:
    
    For LOW_MEMORY, we use 2049 for compatibility with earlier code because callno 2048 leaked out when the intended callno range was 2-2047.


- rmudgett


On Jan. 28, 2013, 1:57 p.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2293/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 1:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While populating the list of available call numbers in IAX2 when LOW_MEMORY is not defined, we use every number between 2 and 32768 (inclusive).  32768 is a 16 bit number (a 1 followed by 15 0s).  According to the IAX2 RFC, call numbers are 15 bit values, making 32768 invalid.
> 
> This patch reduces the number of allocated call numbers by 1 so that the are all 15 bits.
> 
> I intend to commit this change to Asterisk versions 1.8, 11, and trunk.
> 
> I have another patch to replace the ao2_container usage for call number selection almost ready for RB as well.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 380249 
>   /trunk/channels/iax2.h 380249 
> 
> Diff: https://reviewboard.asterisk.org/r/2293/diff
> 
> 
> Testing
> -------
> 
> Ran thousands of test calls (both trunked and non-trunked) between 3 Asterisk servers.
> 
> 
> Thanks,
> 
> Sean
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130128/dbf26af1/attachment.htm>