[asterisk-dev] [Code Review] features/parking: regression - Fallback extensions aren't working when the peer extension does not exist

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2296/#review7757
-----------------------------------------------------------

Ship it!


Looks OK by me.

- rmudgett


On Jan. 28, 2013, 12:48 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2296/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 12:48 p.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> features.conf.sample states that we are supposed to perform these fallbacks, but they were removed from pbx.c in order to solve some unrelated problems in https://reviewboard.asterisk.org/r/1446/diff/#index_header by oej's patch. It seems more appropriate to perform fallbacks like this on an as needed basis rather than relying on the PBX to do so anyway, so that's the motivation for this patch.
> 
> 
> This addresses bug ASTERISK-20716.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20716
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features.c 380247 
> 
> Diff: https://reviewboard.asterisk.org/r/2296/diff
> 
> 
> Testing
> -------
> 
> flat peer extension exists
> flat peer extension does not exist, s at comebackcontext does
> flat peer extension does not exist, s at comebackcontext doesn't either, s at default does
> flat peer extension does not exist, s at comebackcontext doesn't either, also no s at default.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130128/fe03b6c3/attachment.htm>