[asterisk-dev] [Code Review] Fix issues with skinny sessions
opticron
reviewboard at asterisk.org
Thu Jan 17 13:46:30 CST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2272/#review7686
-----------------------------------------------------------
Ship it!
The changes here look good.
- opticron
On Jan. 12, 2013, 2:44 p.m., wedhorn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2272/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2013, 2:44 p.m.)
>
>
> Review request for Asterisk Developers and Brad Latus.
>
>
> Summary
> -------
>
> Fixes a couple of issues with the way skinny handles sessions.
>
> Inserted break in destroy session (as per my comment in https://issues.asterisk.org/jira/browse/ASTERISK-19663 ).
>
> Other changes are to set d->session to null when a session is destroyed and move ast_verbs that use session data to before destroying them.
>
>
> Diffs
> -----
>
> /branches/11/channels/chan_skinny.c 378634
>
> Diff: https://reviewboard.asterisk.org/r/2272/diff
>
>
> Testing
> -------
>
> Reset device and reload skinny. Both worked.
>
>
> Thanks,
>
> wedhorn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/4bf4bb80/attachment.htm>
More information about the asterisk-dev
mailing list