[asterisk-dev] [Code Review]: Add event-triggered origination to the pluggable origination module

[opticron]

> On Jan. 17, 2013, 9:35 a.m., Matt Jordan wrote:
> > asterisk/trunk/lib/python/asterisk/PluggableModules.py, line 37
> > <https://reviewboard.asterisk.org/r/2261/diff/1/?file=32541#file32541line37>
> >
> >     This shouldn't have to be in your default config, as the default trigger value is 'scenario_start'.

The default config also serves as a list of config items to pull from the module config.


> On Jan. 17, 2013, 9:35 a.m., Matt Jordan wrote:
> > asterisk/trunk/lib/python/asterisk/PluggableModules.py, lines 49-54
> > <https://reviewboard.asterisk.org/r/2261/diff/1/?file=32541#file32541line49>
> >
> >     I'd structure this differently.
> >     
> >     If someone specified a trigger value of 'event', check to see if 'event' is in their config. If not, raise an exception - you need to kill the test as they have created an invalid configuration.
> >     
> >     Past the exception, just index into self.config['event'] like you are already.
> >     
> >     As it is, if you specify a trigger of event, the test will start up but never originate anything - meaning they'll have to dig into the test code to figure out why their test just timed out.

Done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2261/#review7676
-----------------------------------------------------------


On Jan. 4, 2013, 9:58 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2261/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 9:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds the capability to have an origination triggered from an arbitrary event received via AMI from any available Asterisk instance.  The AMI listener defaults to the Asterisk instance where the origination will take place.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/PluggableModules.py 3598 
>   asterisk/trunk/sample-yaml/originator-config.yaml.sample 3598 
> 
> Diff: https://reviewboard.asterisk.org/r/2261/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/e342bc9a/attachment.htm>